Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDSC SKHU Web - 이예슬 #12

Merged
merged 6 commits into from Nov 3, 2022
Merged

GDSC SKHU Web - 이예슬 #12

merged 6 commits into from Nov 3, 2022

Conversation

yeaseul7
Copy link
Contributor

@yeaseul7 yeaseul7 commented Nov 2, 2022

Description

구현 및 작업 내용을 적어주세요.

-display:flex 활용
-전체 margin, padding 조절
-전체 text색상 조절

Important content

주의 깊게 봐야 하거나 말하고 싶은 점을 적어주세요.

-display:flex 활용
-flex 조절

Reference

참고한 레퍼런스가 있다면 기록해주세요.

짝궁소개
쓸데없는 파일 삭제
@yeaseul7 yeaseul7 changed the title yeasesul GDSC-WED-이예슬 Nov 2, 2022
Copy link
Member

@hanseulhee hanseulhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예슬님 pr 제목 컨벤션에 맞게 맞춰주시고 .DS_Store 파일 삭제해주세요 ~!

https://dlee0129.tistory.com/250

@yeaseul7 yeaseul7 changed the title GDSC-WED-이예슬 GDSC-SKHU-WED-이예슬 Nov 3, 2022
@yeaseul7 yeaseul7 changed the title GDSC-SKHU-WED-이예슬 GDSC SKHU Web-이예슬 Nov 3, 2022
@hyesungoh
Copy link
Member

예슬님 리드미랑 .DS_Store 파일 제가 수정한 후에 리뷰 남겨 드릴게요 ~

@hyesungoh hyesungoh changed the title GDSC SKHU Web-이예슬 GDSC SKHU Web - 이예슬 Nov 3, 2022
Copy link
Member

@hyesungoh hyesungoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

Comment on lines +9 to +10
background-color: #153180;
color: rgb(197, 219, 255);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

Comment on lines +21 to +23
<!-- a=anchor -->
<!-- c+d-> 똑같음 애들 선택 -->
<!-- tip 같은 요소 3개 있을때 option+shift+방향키 -> 복붙 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Comment on lines +20 to +25
display: flex;
align-items: center;
padding: 0 20px;
font-size: 1.875rem;
display: flex;
flex-direction: column;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
display: flex;
align-items: center;
padding: 0 20px;
font-size: 1.875rem;
display: flex;
flex-direction: column;
display: flex;
align-items: center;
padding: 0 20px;
font-size: 1.875rem;
flex-direction: column;

두 번 쓰신 요소가 있어요 ~

Copy link
Member

@hanseulhee hanseulhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요 👍🏻👍🏻👍🏻 😄

</div>
<div class="box">
저의 짝궁의 취미입니다!
<img class="hobby" src="./img/df934e40d28dae33b9ea8a85aa4569cbd455c616511712c93d878a3cd9d98863109ab1bd99ef31f826c93cd25086ce0fa9a649c33dd1c1bf19577ceb2cf8aa7070751e03ae1c5a7bd5662df37bf82dca.png"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

img 태그에 alt 속성값을 넣어주세요 ~!

@hanseulhee hanseulhee merged commit f1d3e57 into GDSC-SKHU:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants