Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New extension: TweenGroup #774

Closed
3 tasks done
george-gca opened this issue Feb 9, 2023 · 14 comments
Closed
3 tasks done

New extension: TweenGroup #774

george-gca opened this issue Feb 9, 2023 · 14 comments
Labels
Force re-run the bot ⌨ JavaScript Uses JavaScript code, and thereby needs a reviewer who knows JavaScript. ✨ New extension A new extension

Comments

@george-gca
Copy link
Contributor

george-gca commented Feb 9, 2023

Description

Allows you to create a group of objects with tween behavior, performing tween on all of them.

How to use the extension

You need to create an object with the TweenGroup behavior. Then, you need to register some objects in it with the Register object action. These objects MUST HAVE the tween behavior. Then, you just add the wanted tween on the object with TweenGroup behavior and it will also propagate the same tween to the registered objects.

Checklist

  • I've followed all of the best practices.
  • I confirm that this extension can be integrated to this GitHub repository, distributed and MIT licensed.
  • I am aware that the extension may be updated by anyone, and do not need my explicit consent to do so.

What tier of review do you aim for your extension?

Community (Unreviewed)

Example file

Tween Group Example.zip

Extension file

TweenGroup.zip

@george-gca george-gca added the ✨ New extension A new extension label Feb 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

👋 Thanks for your submission! Unfortunately, all submitted extensions have to meet some minimal quality standard - the extension best practices - and our system has found that your extension does not fully comply 😔. You can find all of those rules on the GDevelop wiki.

The following issues have been found by the system concerning the respect of those best practices by your extension:

  ⟶ ❌ [JavaScript disallowed properties]: Found disallowed properties in extension 'TweenGroup':
{
  allowedProperties: [
    'makeUuid',           'rgbToHex',
    'rgbOrHexToRGBColor', 'rgbToHexNumber',
    'hexNumberToRGB',     'hexToRGBColor',
    'copyArray',          'staticArray',
    'staticArray2',       'staticObject',
    'toDegrees',          'toRad',
    'random',             'randomFloat',
    'randomFloatInRange', 'randomInRange',
    'randomWithStep',     'evtTools',
    'Variable',           'RuntimeObject',
    'Logger'
  ],
  disallowedProperty: 'TweenRuntimeBehavior',
  objectName: 'gdjs'
}
{
  allowedProperties: [
    'getVariables',
    'getLayer',
    'getGame',
    'getBackgroundColor',
    'getName',
    'createObject',
    'createObjectsFrom',
    'setBackgroundColor',
    'sceneJustResumed',
    'requestChange',
    'hasLayer',
    'enableDebugDraw'
  ],
  disallowedProperty: 'getObjects',
  objectName: 'runtimeScene'

Please update your original submission post with a new zip file containing your extensions updated to follow those guidelines 🙏

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

👋 Thanks for your submission! Unfortunately, all submitted extensions have to meet some minimal quality standard - the extension best practices - and our system has found that your extension does not fully comply 😔. You can find all of those rules on the GDevelop wiki.

The following issues have been found by the system concerning the respect of those best practices by your extension:

  ⟶ ❌ [JavaScript disallowed properties]: Found disallowed properties in extension 'TweenGroup':
{
  allowedProperties: [
    'makeUuid',           'rgbToHex',
    'rgbOrHexToRGBColor', 'rgbToHexNumber',
    'hexNumberToRGB',     'hexToRGBColor',
    'copyArray',          'staticArray',
    'staticArray2',       'staticObject',
    'toDegrees',          'toRad',
    'random',             'randomFloat',
    'randomFloatInRange', 'randomInRange',
    'randomWithStep',     'evtTools',
    'Variable',           'RuntimeObject',
    'Logger'
  ],
  disallowedProperty: 'TweenRuntimeBehavior',
  objectName: 'gdjs'
}
{
  allowedProperties: [
    'getVariables',
    'getLayer',
    'getGame',
    'getBackgroundColor',
    'getName',
    'createObject',
    'createObjectsFrom',
    'setBackgroundColor',
    'sceneJustResumed',
    'requestChange',
    'hasLayer',
    'enableDebugDraw'
  ],
  disallowedProperty: 'getObjects',
  objectName: 'runtimeScene'

Please update your original submission post with a new zip file containing your extensions updated to follow those guidelines 🙏

@arthuro555 arthuro555 added the ⌨ JavaScript Uses JavaScript code, and thereby needs a reviewer who knows JavaScript. label Mar 19, 2023
@github-actions
Copy link
Contributor

👋 Thanks for your submission! Unfortunately, all submitted extensions have to meet some minimal quality standard - the extension best practices - and our system has found that your extension does not fully comply 😔. You can find all of those rules on the GDevelop wiki.

The following issues have been found by the system concerning the respect of those best practices by your extension:

  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'HasSlid' misses a dot at the end of the sentence!
  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'IsSliding' misses a dot at the end of the sentence!
  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'RegisterObject' misses a dot at the end of the sentence!
  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'AddObjectColorTween' misses a dot at the end of the sentence!
  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'Progress' misses a dot at the end of the sentence!
  ⟶ ❌ [Dots in sentences]: Field 'description' of the behavior 'SlidingWindow' misses a dot at the end of the sentence!
  ⟶ ❌ [Dots in sentences]: Field 'description' of the behavior 'TweenGroup' misses a dot at the end of the sentence!
  ⟶ ❌ [JavaScript disallowed properties]: Found disallowed properties in extension 'TweenGroup':
{
  allowedProperties: [
    'makeUuid',           'rgbToHex',
    'rgbOrHexToRGBColor', 'rgbToHexNumber',
    'hexNumberToRGB',     'hexToRGBColor',
    'copyArray',          'staticArray',
    'staticArray2',       'staticObject',
    'toDegrees',          'toRad',
    'random',             'randomFloat',
    'randomFloatInRange', 'randomInRange',
    'randomWithStep',     'evtTools',
    'Variable',           'RuntimeObject',
    'Logger'
  ],
  disallowedProperty: 'TweenRuntimeBehavior',
  objectName: 'gdjs'
}
{
  allowedProperties: [
    'getVariables',
    'getLayer',
    'getGame',
    'getBackgroundColor',
    'getName',
    'createObject',
    'createObjectsFrom',
    'setBackgroundColor',
    'sceneJustResumed',
    'requestChange',
    'hasLayer',
    'enableDebugDraw'
  ],
  disallowedProperty: 'getObjects',
  objectName: 'runtimeScene'
}

Please update your original submission post with a new zip file containing your extensions updated to follow those guidelines 🙏

@tristanbob
Copy link
Contributor

Can you help me understand how this extension works compared to using an object group to perform a tween?

@george-gca
Copy link
Contributor Author

george-gca commented Apr 7, 2023

Sure.
1 - with it, you can chain tweens with a custom delay. So, for example, you create a group and want that all elements in it do a specific tween with 1s between each element.
2 - you can do tween to relative positions, like, instead of every element goes to X = 40, make all elements add 40 to their current X position

I may be able to fix all the main complaints above, but this:
[JavaScript disallowed properties]: Found disallowed properties in extension 'TweenGroup'

@tristanbob
Copy link
Contributor

tristanbob commented Apr 7, 2023 via email

@george-gca
Copy link
Contributor Author

Sure, the source code and example are right above. As for the ForEach(object), yes, but suppose you want to do this a lot of times, the events sheet would be full of events. Also, encapsulating them into a Behavior makes it an easy to use component.

@infokub
Copy link
Contributor

infokub commented Apr 14, 2023

You can't use custom JS freely (that's what the error says).
You have to use the functions in the list or you will be discarded.

If you can't go over that, you will have to add your authorization in here first:
https://github.com/GDevelopApp/GDevelop-extensions/blob/main/scripts/lib/ExtensionsValidatorExceptions.js#L121

@george-gca
Copy link
Contributor Author

Will fix the code and add my authorization.

george-gca added a commit to george-gca/GDevelop-extensions that referenced this issue Jul 2, 2023
Added TweenGroup GDevelopApp#774 extension `gdjsAllowedProperties` and `runtimeSceneAllowedProperties` exceptions
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

👋 Thanks for your submission! We are kind of confused; Your zip file doesn't seem to contain an extension. Please update your original submission post with a new zip file containing an extension 🙏
If your zip does already contain an extension, make sure your file ends with ".json", and that it is at the root of your zip file (not in a sub folder!), as otherwise it will be unrecognized and ignored by the system. If you've checked and nothing seems wrong with your zip, you can ask a member of the extension team for help 😉

2 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

👋 Thanks for your submission! We are kind of confused; Your zip file doesn't seem to contain an extension. Please update your original submission post with a new zip file containing an extension 🙏
If your zip does already contain an extension, make sure your file ends with ".json", and that it is at the root of your zip file (not in a sub folder!), as otherwise it will be unrecognized and ignored by the system. If you've checked and nothing seems wrong with your zip, you can ask a member of the extension team for help 😉

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

👋 Thanks for your submission! We are kind of confused; Your zip file doesn't seem to contain an extension. Please update your original submission post with a new zip file containing an extension 🙏
If your zip does already contain an extension, make sure your file ends with ".json", and that it is at the root of your zip file (not in a sub folder!), as otherwise it will be unrecognized and ignored by the system. If you've checked and nothing seems wrong with your zip, you can ask a member of the extension team for help 😉

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

👋 Thanks for your submission! Unfortunately, all submitted extensions have to meet some minimal quality standard - the extension best practices - and our system has found that your extension does not fully comply 😔. You can find all of those rules on the GDevelop wiki.

The following issues have been found by the system concerning the respect of those best practices by your extension:

  ⟶ ❌ [JavaScript disallowed properties]: Found disallowed properties in extension 'TweenGroup':
{
  allowedProperties: [
    'makeUuid',           'rgbToHex',
    'rgbOrHexToRGBColor', 'rgbToHexNumber',
    'hexNumberToRGB',     'hexToRGBColor',
    'copyArray',          'staticArray',
    'staticArray2',       'staticObject',
    'toDegrees',          'toRad',
    'random',             'randomFloat',
    'randomFloatInRange', 'randomInRange',
    'randomWithStep',     'evtTools',
    'Variable',           'RuntimeObject',
    'Logger'
  ],
  disallowedProperty: 'TweenRuntimeBehavior',
  objectName: 'gdjs'
}
{
  allowedProperties: [
    'getVariables',
    'getLayer',
    'getGame',
    'getBackgroundColor',
    'getName',
    'createObject',
    'createObjectsFrom',
    'setBackgroundColor',
    'sceneJustResumed',
    'requestChange',
    'hasLayer',
    'enableDebugDraw'
  ],
  disallowedProperty: 'getObjects',
  objectName: 'runtimeScene'
}

Please update your original submission post with a new zip file containing your extensions updated to follow those guidelines 🙏

@github-actions
Copy link
Contributor

Hi @arthuro555! 👋 This submission has passed all required tests, and has been moved to a PR as part of our submission pipeline. You can see the progress of your submission on this page. Community submissions are not reviewed by default, so your extension should be added once we've checked that your submission doesn't contain malicious code without further intervention on your part. If you wish for your extension to be reviewed (and thereby moved to the list of reviewed extensions), please follow the instructions written on the README. Thanks again for your contribution to GDevelop!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Force re-run the bot ⌨ JavaScript Uses JavaScript code, and thereby needs a reviewer who knows JavaScript. ✨ New extension A new extension
Projects
None yet
Development

No branches or pull requests

4 participants