[CrazyGame] Fix the action to display a video ads #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…video ads isn't ready (Thanks to MartijnKuilema)
D8H
reviewed
May 11, 2024
| @@ -349,6 +349,7 @@ | |||
| " },", | |||
| " adError: (error, errorData) => {", | |||
| " gdjs._crazyGamesExtension.isPlayingVideoAd = false;", | |||
| " gdjs._crazyGamesExtension.hasVideoAdJustFinishedPlaying = true;", | |||
There was a problem hiding this comment.
Is it to ensure that games won't be stuck if they forgot to handle errors?
Should there be a way for creators to still check if it has finished because of an error?
I guess it's to comply to this:
Often, the request for a midgame ad will be unfilled (either because of timing restrictions, adblock, or low demand). In this case you receive an adError event. You should handle this case correctly and ensure that the game continues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the action to display video ads, now a error is returned if the ad isn't ready (Thanks to MartijnKuilema)