Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stay On Screen] Fix max X and max Y of the object position #298

Merged
merged 1 commit into from
Nov 20, 2021

Conversation

Bouh
Copy link
Contributor

@Bouh Bouh commented Nov 19, 2021

Tested in fullscreen and windowed with the hitbox debugger, it's works fine now.

@4ian
Copy link
Collaborator

4ian commented Nov 19, 2021

This won't work for objects having their origin not at 0;0 though right?

@Bouh
Copy link
Contributor Author

Bouh commented Nov 19, 2021

This won't work for objects having their origin not at 0;0 though right?

Indeed like on the existing live version.

@4ian
Copy link
Collaborator

4ian commented Nov 20, 2021

Ok, let's go ahead with this but we should rework this and the expressions we have to expose the AABB of an object I think.
I think we had other extensions wanting to compute the bounds/the center of an object and they could not, because CenterX/Y can also be changed as it's the center of rotation.

@4ian 4ian merged commit ec628fa into main Nov 20, 2021
@4ian 4ian deleted the fix_StayOnScreen branch November 20, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants