Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New extension: Get Properties Data #596

Merged
merged 3 commits into from
Sep 25, 2022
Merged

New extension: Get Properties Data #596

merged 3 commits into from
Sep 25, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Description

Get Version, Title, Publisher name, PackageName from properties tab.

How to use the extension

Tutorial here
https://www.youtube.com/watch?v=rCuPJYjtje8

Checklist

  • I've followed all of the best practices.
  • I confirm that this extension can be integrated to this GitHub repository, distributed and MIT licensed.
  • I am aware that the extension may be updated by anyone, and do not need my explicit consent to do so.

What tier of review do you aim for your extension?

Reviewed

Example file

GetPropertiesData.zip

Extension file

GetPropertiesData.zip

@github-actions github-actions bot requested a review from a team as a code owner September 25, 2022 11:08
@github-actions github-actions bot added the ✨ New extension A new extension label Sep 25, 2022
@github-actions github-actions bot added this to Needs review in Extensions review Sep 25, 2022
@github-actions github-actions bot mentioned this pull request Sep 25, 2022
3 tasks
@VegeTato VegeTato added the 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging. label Sep 25, 2022
@Bouh Bouh self-requested a review September 25, 2022 11:32
@Bouh Bouh self-assigned this Sep 25, 2022
@Bouh
Copy link
Contributor

Bouh commented Sep 25, 2022

Hi @UlisesFreitas

Thanks for this extension!
Look good to me for a v1, below one or two optionnal suggestion under the checklist.

Extension Best Practices (link)

  • Extension Options
    • Name
    • Versioning
    • Descriptions
    • Tags
    • Help URL
  • Extension definitions
    • Action and conditions
    • Don't use abbreviations
    • Affirmative tense
    • Be oriented toward everyone not just programmers
    • Expressions
    • Custom Behaviors
  • Events in the extension
    • Variables
    • Timers
    • Compatibility
    • Javascript

The Javascript section is not approved because the scope of the extension is global, see in the guide what to do to be correctly scoped.

Suggestion (optionnal)

  • What do you think of Project properties or even better Game properties data?
  • The help path should redirect to the documentation to help to use the extension, but I think it's fine, expressions are simple to use.
  • There are also many other properties, maybe some of them can be cool to add, this is up to you, and below is the complete list of properties.

image

@UlisesFreitas
Copy link

Hi @Bouh I like this name "Game properties data" letme add some other Expressions Strings to get more info and I submit an update soon.

@UlisesFreitas
Copy link

Hi @Bouh Updated added a lot of methods but I couldn't find properties.description.

All the possibilities
Add an string expression that returns the current game version from game properties tab.
Add an string expression that returns the game title from game properties tab.
Add an string expression that returns the game publisher name from game properties tab.
Add an string expression that returns the package name from game properties tab.
Add an string expression that returns the orientation from game properties.
Add an string expression that returns the window width from game properties.
Add an string expression that returns the window height from game properties.
Add an string expression that returns the maxFPS from game properties.
Add an string expression that returns the minFPS from game properties.
Add an string expression that returns the scale mode from game properties.
Add an string expression that returns the pixel rounding from game properties.
Add an string expression that returns the scale mode from game properties.
Add an string expression that returns the vertical sync from game properties.

GetPropertiesDataJson.zip (Extension)
GetPropertiesData.zip (Example)

@Bouh
Copy link
Contributor

Bouh commented Sep 25, 2022

!update GetPropertiesDataJson.zip

@github-actions
Copy link
Contributor Author

✅ Successfully updated the extension.

@Bouh Bouh merged commit aca47a5 into main Sep 25, 2022
Extensions review automation moved this from Needs review to Added to GDevelop Sep 25, 2022
@Bouh Bouh deleted the extension/UlisesFreitas/595 branch September 25, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ New extension A new extension 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging.
Projects
Extensions review
  
Added to GDevelop
Development

Successfully merging this pull request may close these issues.

None yet

3 participants