Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clearCookie #12

Merged
merged 2 commits into from
May 7, 2021
Merged

add clearCookie #12

merged 2 commits into from
May 7, 2021

Conversation

jurihahn
Copy link
Contributor

@jurihahn jurihahn commented May 7, 2021

function to delete all cookies

for #10

function to delete all cookies
Copy link
Collaborator

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me and I did not find any issues with a short test. Thank you for this.

Good job 🥇

@NiklasMerz
Copy link
Collaborator

Documentation for this function would be awesome.

I will merge this for the next version but I might take some time for a release as I am waiting for the next cordova-android release.

@NiklasMerz NiklasMerz linked an issue May 7, 2021 that may be closed by this pull request
@NiklasMerz NiklasMerz added this to the 1.0.0 milestone May 7, 2021
@jurihahn
Copy link
Contributor Author

jurihahn commented May 7, 2021

small info about clearCookie function added

@NiklasMerz NiklasMerz merged commit 0e5bfc9 into GEDYSIntraWare:master May 7, 2021
@NiklasMerz
Copy link
Collaborator

Thanks. Awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all cookie if device is offline
2 participants