Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cached_property and union operator for backwards compatibility #69

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

j-chim
Copy link
Contributor

@j-chim j-chim commented Nov 2, 2021

Currently the library requires Python >= 3.9 due to using functools.cached_property and dict union. This creates a problem for users who can't easily change versions/environments (eg Colab/Kaggle).

(also see: #61)

This PR makes the library backwards compatible and has been tested on 3.7.

@tuetschek
Copy link
Collaborator

Looks good to me. @sebastianGehrmann OK to merge?

@sebastianGehrmann
Copy link
Contributor

Yep looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants