Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate sites data from materials input #16

Closed
28 tasks done
stefsmeets opened this issue Jun 27, 2023 · 2 comments
Closed
28 tasks done

Calculate sites data from materials input #16

stefsmeets opened this issue Jun 27, 2023 · 2 comments

Comments

@stefsmeets
Copy link
Contributor

stefsmeets commented Jun 27, 2023

This issue tracks processing the 'known materials' data and calculating sites data.

Features

Variables

@stefsmeets
Copy link
Contributor Author

stefsmeets commented Jun 27, 2023

EDIT: solved by #18


One of the issues I'm running into is a mismatch between the known materials and data in the simulation.

In our sample data, for argyrodite, the reported space group symmetry is $F\overline{4}3m$ (cubic). The sites in known materials are for 48h, which only exist in the cubic space group. The lattice in the simulation is triclinic (a=19.87, b=9.92, c=9.92, al=90.21, be=90.86, ga=89.95). These don't match.

This makes it difficult to define the sites in a standard crystallographic format.

@stefsmeets
Copy link
Contributor Author

I think we got everything now, this issue can be closed! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant