Add implementation for calculating site transitions #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an implementation to calculate site transitions.
This code covers everything until line 156 in
find_sites.m
.Data are loaded from a cif file, which means they cannot be compared directly to the matlab data (the order of the sites and thus coordinates is different).
The result differs slightly, I think because of rounding errors.
Todo
succes
arraytransitions
arrayoccupancy
arrayoccupancy_parts
arrayatom_sites
arrayvibration_amplitude
from some sort of cache or calculate it on-the-fly (Maybe apreprocess(Data)
to get everything at once?) -> Structure the calculations, data now has a calculate_all function #20