-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vibrational properties #11
Conversation
Hi @v1kko this PR is ready, what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but keep in mind that we have to change the structure around a bit still.
Of course the added plot functions will stay mostly the same so those are great!
The name (probably will) change as well in the future, so you don't have to change it now (unless you are really annoyed by CAPITALS 😛 ).
Cheers, no worries about changing the structure! And yes, I'm already super annoyed by the CAPITALS. Already too many times I have had |
This PR reads some more variables from the
vasprun.xml
and calculates the vibrational properties.Todo
meanfreq
functionPlots