Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ABACGuard to call execute_ABAC_query, not ABACManager.query #213

Closed
MarshallBrinn opened this issue May 20, 2015 · 1 comment
Closed
Assignees
Milestone

Comments

@MarshallBrinn
Copy link
Contributor

The ABACManager has three modes for evaluating queries:

  1. Running the standard ABAC library context engine internally to the process
  2. Running the standard ABAC library context engine as an external process
  3. Running an internal quick prover that assumes everything is signed by "ME" (the authority).

Currently most ABAC queries are done with #2 since #1 has some memory leak issues. But the queries done in ABACGuard.authorize_call uses ABACManager.query which is configured to use the internal quick prover.

We should change this to call the standard ABAC library context engine as an external process so that we are using a standard mechanism for making policy decisions.

Imported from trac ticket #213, created by mbrinn on 01-22-2014 at 15:04, last modified: 02-08-2014 at 11:11

@MarshallBrinn MarshallBrinn self-assigned this May 20, 2015
@MarshallBrinn MarshallBrinn added this to the GEC19 milestone May 20, 2015
@MarshallBrinn
Copy link
Contributor Author

We have the fix to this sitting in a chapi branch tkt213_abacguard_query. But it proves to be much too slow for the number of calls we make to the ABAC manager. Either we need to fix the memory leak in ABAC so we can all it internally, or we need to change the pattern of calling, or we need to continue to use ABACManager.query. But this proposed fix is not the right way to go.

Trac comment by mbrinn (github user: MarshallBrinn) on 02-08-2014 at 11:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant