Fix GENI Portal XSS vulnerability issues reported #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the invocation id and invocation user cannot be anything but an alphanumeric string , we will use that check as our fix . This will avoid the usage of any JS code as values since it would need special chars like "<>"
My fix here was just to urldecode and remove all instances of HTML chars that could be executed as JS
This one was tricky to fix. This PHP is used by other PHP scripts and the rspec validation is done 3 levels down after the file is uploaded. The bug is triggered during one of these handoffs from php file to file. The right way to fix this would have been to validate the file uploaded right here. I did try to do that using some of the subroutines defined in other scripts, but all of them seem to allow the malicious JS/HTML code to pass thru since they are valid XML/HTML , but just no rspec related stuff in it. SO my quick and dirty fix for this is to load the string into a XML DOM and loo for the "script" TAG and throw an error if one is seen. RSPEC should not have a SCRIPTS tag in it. Period !!!
Fix XSS Vul for $invocation_user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1823