Updates in HEDIS and GLRES module. #161
Conversation
|
Three main updates in this merge request:
|
pochoarus
changed the title
|
These changes were made to introduce the scattering with the photon field and the Glashow resonance NLO calculations. A new module called HELepton has been created to simulate these events. |
| @@ -78,6 +80,8 @@ class ScatteringType | |||
| case(kScInverseBetaDecay) : return "IBD"; break; | |||
| case(kScGlashowResonance) : return "GLR"; break; | |||
| case(kScIMDAnnihilation) : return "IMDAnh"; break; | |||
| case(kScPhotonRES) : return "PhotonRES"; break; | |||
There was a problem hiding this comment.
Perhaps, can we have some better naming uniformity here? We have 'kScGlashowResonance', and 'kScPhotonRES'. We have 'kScCoherentProduction' and 'kScPhotonCOH'. Maybe we can fully spell out the 'resonance', 'coherent' in the kSc** enum, and use the short 'RES', 'COH' version in the string that this code returns?
There was a problem hiding this comment.
Sorry for the delay. I will make the changes to the naming convention.
| </param_set> | ||
|
|
||
| </alg_conf> | ||
|
|
There was a problem hiding this comment.
Do we have some kind of documentation of all the channels simulated in the HEDIS package now. This whole thing evolved to a substantial package with a lot of simulation capabilities. Can you consider some contribution to the physics section of the manual?
There was a problem hiding this comment.
This is a good point. So far, we explain these models in the following papers:
https://arxiv.org/abs/1908.10077
https://arxiv.org/abs/2004.04756
I think it is a good idea to include a section in the manual explaining how to run them. As soon as I have a bit of time, I will make this new section.
|
Perhaps if we can quickly address some naming inconsistency highlighted above, could merge and publish in 3.2? |
|
Merging fine with me @pochoarus. Let's discuss separately about some relevant additions to the User and Physics manual. This is the second most cited GENIE paper, with 200 citations, though it is only a very early draft posted on arXiv. Would be good to update that arXiv eprint by summer. We already have a much improved version, but needs a bit more work on a few sections. |
|
Perfect. I will start working on a new draft in the next weeks. Who is in charge of doing the actual merge? I guess is @mroda88? |
|
Yes, I think @mroda88 was going to merge some time later today. @pochoarus can you clarify for the release notes? GHE19_00a is BGR18, GHE19_00b is CMS11 model, and GHE19_00d is GGHR20. Then what is GHE19_00c? Also, do all a-d include all the new processes from HELepton. From a look at configs, I seem to think the answer is yes but can you confirm. |
|
I'll start having a look. Hopefully we can have it done by next week |
|
Actually, I've realized that a,c, and d configs didn't include some of the new channels. I've just fixed it. Regarding the HEDIS model in each tune, it is as follows:
|
|
There are still some configuration issues. Basically there are some incompatibilities with some local EventGenerator.xml files deployed in some tune subdirectories. I'll try to create a dedicated branch with the correct changes in the main repo. So I'll do a provisional merge there. |
|
#197 is merged instead of this one |
No description provided.