Fix build #4
Closed
Fix build #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrong variables from pkg_check_modules were used, effectively forcing the inclusion of dlt.h to happen from /include. Fix this to take advantage of pkg-config and allow building against a non-system-wide dlt-daemon.
The -L flags were not retrieved from pkg_check_modules, except for automotive-dlt, where LDFLAGS was added to the LIBS variable, which was then passed to TARGET_LINK_LIBRARIES. This led to compile-time errors when compiling in a custom prefix. We also propagate the LIB_DIRECTORIES and use them in AmControlInterfaceTest and AudioManagerDaemon.
The regeression was introduced by 791557b, fix it in a similar fashion.
MathieuDuponchelle
force-pushed
the
fix_build
branch
from
9bc1da7
to
cd71637
Compare
pkg-config looks for the exact, case-sensitive names listed in the requirements.
MathieuDuponchelle
added a commit
to MathieuDuponchelle/AudioManagerPlugins
that referenced
this pull request
Oct 26, 2016
There were two issues on my machine: The dependencies are installed in a custom prefix, we thus make use of the newly-defined AudioManagerUtilities_LIB_DIRECTORIES variable (see GENIVI/AudioManager#4) -std=gnu++11 -Wno-variadic-macro needed to be set in the CXXFLAGS
First issue is that libraries might be installed to lib64, not lib. Second issue is that these libraries aren't installed in $(libdir)/audiomanager , simply $(libdir), thus adding the suffix is wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing various issues encountered when building the AudioManager with the default options in a custom prefix (-DCMAKE_INSTALL_PREFIX=[...])