LayerManagerControl: add two subcmd for add/remove a surface to/from a layer. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zeerd, |
zeerd
changed the title
|
i am not sure how to change it. |
|
Hi @efriedrich OK, seems it worked. |
|
HI @zeerd,yes thanks i see the update, sorry but I forgot to mention also one important genivi community rule: |
…a layer. For more testing chance from the command line. Signed-off-by: Emneg Zeerd <emneg.zeerd@gmail.com>
|
Hi, @efriedrich I added it. |
marex
pushed a commit
to marex/wayland-ivi-extension
that referenced
this pull request
Jan 23, 2022
The seat destroy callback is triggered from weston_seat_release(), that means the only way the code can enter destroy_seat() is with all input devices associted with seat already released and all the pointers already invalid. Avoid touching any of these input device pointers in the destroy_seat() callback, otherwise this triggers use-after-free condition. ASan detects the use-after-free condition as follows: ``` ==89420==ERROR: AddressSanitizer: heap-use-after-free on address 0x61100028e6a0 at pc 0x7f50deacb6fd bp 0x7ffed8504fe0 sp 0x7ffed8504fd8 WRITE of size 8 at 0x61100028e6a0 thread T0 #0 0x7f50deacb6fc in weston_keyboard_end_grab ../libweston/input.c:1604 COVESA#1 0x7f50bc6aac97 in destroy_seat (/tmp/wt/lib/x86_64-linux-gnu/weston/ivi-input-controller.so+0x7c97) COVESA#2 0x7f50bc6ab02f in handle_seat_destroy (/tmp/wt/lib/x86_64-linux-gnu/weston/ivi-input-controller.so+0x802f) COVESA#3 0x7f50deac477d in wl_signal_emit /usr/include/wayland-server-core.h:478 COVESA#4 0x7f50dead5a93 in weston_seat_release ../libweston/input.c:3490 COVESA#5 0x7f50bc6973d0 in ss_seat_destroy ../compositor/screen-share.c:395 COVESA#6 0x7f50bc69922c in registry_handle_global_remove ../compositor/screen-share.c:751 COVESA#7 0x7f50de8b89d9 (/lib/x86_64-linux-gnu/libffi.so.8+0x79d9) COVESA#8 0x7f50de8b7b20 (/lib/x86_64-linux-gnu/libffi.so.8+0x6b20) COVESA#9 0x7f50dea582d1 (/lib/x86_64-linux-gnu/libwayland-client.so.0+0x92d1) COVESA#10 0x7f50dea54979 (/lib/x86_64-linux-gnu/libwayland-client.so.0+0x5979) COVESA#11 0x7f50dea5603b in wl_display_dispatch_queue_pending (/lib/x86_64-linux-gnu/libwayland-client.so.0+0x703b) COVESA#12 0x7f50bc69931a in shared_output_handle_event ../compositor/screen-share.c:771 COVESA#13 0x7f50dea434b1 in wl_event_loop_dispatch (/lib/x86_64-linux-gnu/libwayland-server.so.0+0xb4b1) COVESA#14 0x7f50dea41134 in wl_display_run (/lib/x86_64-linux-gnu/libwayland-server.so.0+0x9134) COVESA#15 0x7f50deed8489 in wet_main ../compositor/main.c:3564 COVESA#16 0x55961496217d in main ../compositor/executable.c:33 COVESA#17 0x7f50dece97ec in __libc_start_main ../csu/libc-start.c:332 COVESA#18 0x559614962099 in _start (/tmp/wt/bin/weston+0x1099) ``` Signed-off-by: Marek Vasut <marex@denx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for more testing from the command line.