Assign layer as request param for queries #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbauszus-glx
requested review from
RobAndrewHurst,
simon-leech,
cityremade and
eo-uk
|
Kudos, SonarCloud Quality Gate passed!
|
simon-leech
approved these changes
Nov 14, 2023
dbauszus-glx
added
the
Bug
cityremade
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries which have the layer param need to access the layer object which may be constructed from templates. The query module gets the layer from the getLayer mod. The layer object will replace the req.params.layer string and be accessible in query methods.
A query may access templates as referenced by fields. The templates must be available as string and not be loaded from a src.