renamed color var, added new color var, changed bg color of drawer #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eo-uk
added
the
Feature
eo-uk
requested review from
dbauszus-glx,
cityremade,
RobAndrewHurst and
simon-leech
simon-leech
requested changes
Nov 16, 2023
There was a problem hiding this comment.
I much prefer the colour scheme but i've got a few thoughts - happy to be overruled though!
- The layer key is not apparent anymore.
- On the tabview, there's no longer a distinction between the tabview tabs and the information, which results in a vertical line that just ends and isn't super clear why.
3. I don't think there's enough distinction between layer groups and individual layers. What about if layer groups have a bold header and layers were not bolded?
simon-leech
approved these changes
Nov 17, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed color palette, renamed the color-lighter variable to color-light-secondary and added another variation. Adjusted drawer background for a subtler background.