Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide layer key as snap option #1027

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

dbauszus-glx
Copy link
Member

@dbauszus-glx dbauszus-glx commented Dec 4, 2023

Instead of snap:true it should be possible to provide a layer key.

"polygon": {
  "snap": {
    "layer": "iuc"
  }
}

https://github.com/GEOLYTIX/xyz/wiki/Workspace-Configuration#snap

@dbauszus-glx dbauszus-glx added the Feature New feature requests or changes to the behaviour or look of existing application features. label Dec 4, 2023
@simon-leech simon-leech self-requested a review December 12, 2023 17:19
Copy link

sonarcloud bot commented Dec 12, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbauszus-glx I noticed if you provide a bogus layer key you get no warning or error, and the layer itself is defined as the snap layer. I think this should be explicit with a warning, so I pushed a commit to do this - let me know what you think.

The functionality is all working for me though!

@RobAndrewHurst RobAndrewHurst merged commit 249264c into GEOLYTIX:main Dec 13, 2023
5 checks passed
@dbauszus-glx dbauszus-glx deleted the snap-layer branch January 29, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature requests or changes to the behaviour or look of existing application features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants