Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wkt_properties feature format and mvt queries #1029

Merged
merged 7 commits into from
Dec 18, 2023

Conversation

dbauszus-glx
Copy link
Member

@dbauszus-glx dbauszus-glx commented Dec 5, 2023

It should be possible to request feature properties for the viewport separate from the tile (geometries).

The wkt_properties() featureFormat method processes wkt features without geometries. The feature properties are assigned with the feature [id] key to the layer.featuresObject{}.

The openlayers layer.L.changed() is used to re-style the layer after the feature properties are loaded. The removes the need to hook into the tile load and rendered methods.

Only the feature properties need to be loaded if the current layer filter are changed.

Having filter statistics will allow to create dynamic themes and legends which can use viewport statistics of loaded features.

The mvt_geom query will ignore the any filters. This will allow to create tile caches for shared geometries.

The wkt_properties:true flag will enable this mode for mvt layer.

The [tile] cachSize can be configured as an integer on the layer.

@dbauszus-glx dbauszus-glx added Feature New feature requests or changes to the behaviour or look of existing application features. Code Issues related to the code structure and performance. labels Dec 5, 2023
@dbauszus-glx dbauszus-glx linked an issue Dec 5, 2023 that may be closed by this pull request
@dbauszus-glx dbauszus-glx marked this pull request as ready for review December 6, 2023 10:06
Copy link
Contributor

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

When using a format: mvt layer with setLabels on themes, I am ending up with multiple labels drawn to the mapview.

@dbauszus-glx
Copy link
Member Author

An mvt layer with zoom level table restrictions should not make requests if there is no table.

Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@simon-leech simon-leech dismissed their stale review December 14, 2023 19:01

Incorrect review, issues amended

@RobAndrewHurst RobAndrewHurst merged commit 995b4e2 into GEOLYTIX:main Dec 18, 2023
5 checks passed
@dbauszus-glx dbauszus-glx deleted the mvt-geom-prop branch January 29, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Issues related to the code structure and performance. Feature New feature requests or changes to the behaviour or look of existing application features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MVT: Tile (geometry) requests and property requests
3 participants