-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wkt_properties feature format and mvt queries #1029
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbauszus-glx
added
Feature
New feature requests or changes to the behaviour or look of existing application features.
Code
Issues related to the code structure and performance.
labels
Dec 5, 2023
dbauszus-glx
requested review from
simon-leech,
RobAndrewHurst,
cityremade and
eo-uk
December 5, 2023 16:24
simon-leech
previously requested changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An mvt layer with zoom level table restrictions should not make requests if there is no table. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
RobAndrewHurst
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be possible to request feature properties for the viewport separate from the tile (geometries).
The
wkt_properties()
featureFormat method processes wkt features without geometries. The feature properties are assigned with the feature [id] key to thelayer.featuresObject{}
.The openlayers
layer.L.changed()
is used to re-style the layer after the feature properties are loaded. The removes the need to hook into the tile load and rendered methods.Only the feature properties need to be loaded if the current layer filter are changed.
Having filter statistics will allow to create dynamic themes and legends which can use viewport statistics of loaded features.
The
mvt_geom
query will ignore the any filters. This will allow to create tile caches for shared geometries.The
wkt_properties:true
flag will enable this mode for mvt layer.The [tile]
cachSize
can be configured as an integer on the layer.