Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abort dataset gazetteer XHR #1042

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Abort dataset gazetteer XHR #1042

merged 2 commits into from
Dec 20, 2023

Conversation

dbauszus-glx
Copy link
Member

The abort was previously inside the search method which has no reference to the dataset on subsequent iterations.

@dbauszus-glx dbauszus-glx added the Bug A genuine bug. There must be some form of error exception to work with. label Dec 19, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 20, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

simon-leech
simon-leech approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well for me and I'm not seeing duplicated results.
I noticed while testing with searching for coordinates that there was a spelling mistake in lib\ui\Gazetteer.mjs so I corrected that and pushed it.

@dbauszus-glx dbauszus-glx merged commit 7ec14ff into GEOLYTIX:main Dec 20, 2023
5 checks passed
@dbauszus-glx dbauszus-glx deleted the gazetteer-xhr-abort branch January 29, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-leech simon-leech simon-leech approved these changes

@cityremade cityremade Awaiting requested review from cityremade

@RobAndrewHurst RobAndrewHurst Awaiting requested review from RobAndrewHurst

@eo-uk eo-uk Awaiting requested review from eo-uk

Assignees
No one assigned
Labels
Bug A genuine bug. There must be some form of error exception to work with.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dbauszus-glx @simon-leech