Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Options Query #1054

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Edit Options Query #1054

merged 1 commit into from
Jan 3, 2024

Conversation

simon-leech
Copy link
Contributor

Minor change here.

  1. Added id to the params for the query for edit.options.query
  2. Added a no result message as previously this would fail
  3. Added a translation for the no result message.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@simon-leech simon-leech marked this pull request as ready for review January 3, 2024 10:14
dbauszus-glx
dbauszus-glx approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@dbauszus-glx dbauszus-glx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working as expected.
image

@dbauszus-glx dbauszus-glx merged commit f4c3bbc into GEOLYTIX:main Jan 3, 2024
5 checks passed
@simon-leech simon-leech deleted the edit-query-change branch February 9, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbauszus-glx dbauszus-glx dbauszus-glx approved these changes

@RobAndrewHurst RobAndrewHurst Awaiting requested review from RobAndrewHurst

@eo-uk eo-uk Awaiting requested review from eo-uk

@cityremade cityremade Awaiting requested review from cityremade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simon-leech @dbauszus-glx