Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to load workspace #1063

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Conversation

dbauszus-glx
Copy link
Member

A 500 'Failed to load workspace.' error should be returned instead of the zero/OSM only workspace if the workspace cache fails.

The instance should not crash.

The error should be logged to the node console.

@dbauszus-glx dbauszus-glx added the Bug A genuine bug. There must be some form of error exception to work with. label Jan 12, 2024
Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well for me - tested with a file path that wasn't accessible and i see error in the terminal for no such file or directory and the instance loads up the error message - good with me!

Copy link
Contributor

@RobAndrewHurst RobAndrewHurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@RobAndrewHurst RobAndrewHurst merged commit bdd97bf into GEOLYTIX:main Jan 15, 2024
5 checks passed
@dbauszus-glx dbauszus-glx deleted the workspace-err branch February 8, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A genuine bug. There must be some form of error exception to work with.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants