Typeof function check

[RobAndrewHurst]

TypeOf 'Function' PR Summary 📖

Changes Made

This pull request introduces improvements to our codebase by incorporating the typeof check to ensure that certain properties are functions before attempting to execute them in the layer decorate and in the default view's javascript.

1. Handling Layer and Plugin Methods

   • In the code responsible for handling layer and plugin methods, we have added typeof checks to verify whether the properties are functions before attempting to execute them. This enhancement aims to prevent potential errors when invoking methods that might not be functions.

   Object.keys(layer).forEach((key) => {
           // Check if mapp.layer[key] is a function before executing it
           typeof mapp.layer[key] === 'function' && mapp.layer[key](layer);
   
           // Or plugin method and provide the layer object as an argument.
           typeof mapp.plugins[key] === 'function' && mapp.plugins[key](layer);
   
           // It is possible to have a plugin method of the same name as a layer method.
       }
   });

Motivation

The motivation behind these changes is to enhance the robustness of the code by explicitly checking the types of properties before executing them. By ensuring that methods are functions, we reduce the risk of potential runtime errors in the codebase and other custom views.

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[simon-leech]

Nice one @RobAndrewHurst - looking good to me! 🎉

[dbauszus-glx]

lgtm