Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide string array argument as filter for ui.location.infoj(loc, []) #1083

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

dbauszus-glx
Copy link
Member

@dbauszus-glx dbauszus-glx commented Jan 25, 2024

If the infoj argument is provided as an array of strings a lookup for the entry with matching field will be attempted at the beginning of the iteration.

This does not backwards compatibility where the infoj argument is provided as an array of objects.

image

@dbauszus-glx dbauszus-glx added the Feature New feature requests or changes to the behaviour or look of existing application features. label Jan 25, 2024
Copy link
Contributor

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @dbauszus-glx - this is a clean solution!

📃 Please could you write this up in the Docs? then I'll be happy to approve!

@dbauszus-glx
Copy link
Member Author

https://github.com/GEOLYTIX/xyz/wiki/MAPP.UI#infojlocation-infoj

Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@RobAndrewHurst RobAndrewHurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me!

@dbauszus-glx dbauszus-glx merged commit 5e3428d into GEOLYTIX:main Jan 29, 2024
5 checks passed
@dbauszus-glx dbauszus-glx deleted the infoj-fieldarray branch March 15, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature requests or changes to the behaviour or look of existing application features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants