Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move default btn methods to plugins #1088

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

dbauszus-glx
Copy link
Member

locator, zoomToArea, and fullscreen behave exactly like plugins.

These 'default' plugins have been moved to the plugins module from the default view to clean up the default view.

Methods have been moved out of the tag for better maintenance and linting.

Copy link
Contributor

@AlexanderGeere AlexanderGeere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in bugs and testing. Plugins still, code looks good

Copy link
Contributor

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working for me when using locator: {} as per this PR.
❓However, this fails if I use the currently applied configuration prior to this PR of locator: true. As such, should this be referred to as a breaking change as it fails against current configuration?
❓I also noted that you cannot hide this default plugins, i'm unsure if we should allow that but should this be possible to set locator:false to remove it?
📃 Please can you update the Config Docs to include this? For instance https://github.com/GEOLYTIX/xyz/wiki/Workspace-Configuration#locator this amending.

@dbauszus-glx
Copy link
Member Author

@simon-leech The plugin must accept a true flag. I did a commit for this. I agree that the default should be off. We should discuss what's the preferred setting for the default view.

Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dbauszus-glx dbauszus-glx added the Code Issues related to the code structure and performance. label Jan 26, 2024
@dbauszus-glx
Copy link
Member Author

@simon-leech can you re-review. The requested changes have been made.

@RobAndrewHurst
Copy link
Contributor

image

@dbauszus-glx Is there a reason why there is a plugin param being passed to the function but isn't used?

@dbauszus-glx
Copy link
Member Author

@RobAndrewHurst No particular reason. It's just the default first param for these type of plugin methods. Could be null but doesn't hurt to know what the first param is.

@dbauszus-glx dbauszus-glx dismissed simon-leech’s stale review January 29, 2024 09:32

Changes have been amended.

@dbauszus-glx dbauszus-glx merged commit 7313134 into GEOLYTIX:main Jan 29, 2024
5 checks passed
@dbauszus-glx dbauszus-glx deleted the default-view-plugins branch March 15, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Issues related to the code structure and performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants