-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move default btn methods to plugins #1088
Move default btn methods to plugins #1088
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in bugs and testing. Plugins still, code looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working for me when using locator: {}
as per this PR.
❓However, this fails if I use the currently applied configuration prior to this PR of locator: true
. As such, should this be referred to as a breaking change as it fails against current configuration?
❓I also noted that you cannot hide this default plugins, i'm unsure if we should allow that but should this be possible to set locator:false
to remove it?
📃 Please can you update the Config Docs to include this? For instance https://github.com/GEOLYTIX/xyz/wiki/Workspace-Configuration#locator this amending.
@simon-leech The plugin must accept a true flag. I did a commit for this. I agree that the default should be off. We should discuss what's the preferred setting for the default view. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
@simon-leech can you re-review. The requested changes have been made. |
@dbauszus-glx Is there a reason why there is a |
@RobAndrewHurst No particular reason. It's just the default first param for these type of plugin methods. Could be null but doesn't hurt to know what the first param is. |
locator, zoomToArea, and fullscreen behave exactly like plugins.
These 'default' plugins have been moved to the plugins module from the default view to clean up the default view.
Methods have been moved out of the tag for better maintenance and linting.