Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to define the attribution target #1103

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Allow to define the attribution target #1103

merged 1 commit into from
Jan 31, 2024

Conversation

dbauszus-glx
Copy link
Member

It must be possible to define the target of the attribution.

In the case of the default mapview the attribution must be assigned to the #Map parent element of the #OL mapview.target.

This is to allow for the attribution to float with the tabview and not over it.

@dbauszus-glx dbauszus-glx added the Bug A genuine bug. There must be some form of error exception to work with. label Jan 30, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

RobAndrewHurst
RobAndrewHurst approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@RobAndrewHurst RobAndrewHurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

simon-leech
simon-leech approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the described issue for me!

@dbauszus-glx dbauszus-glx merged commit 4bf2d09 into GEOLYTIX:main Jan 31, 2024
5 checks passed
@dbauszus-glx dbauszus-glx deleted the mapview-attribution-target branch March 15, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobAndrewHurst RobAndrewHurst RobAndrewHurst approved these changes

@simon-leech simon-leech simon-leech approved these changes

@cityremade cityremade Awaiting requested review from cityremade

@AlexanderGeere AlexanderGeere Awaiting requested review from AlexanderGeere

@willjohnsonnn willjohnsonnn Awaiting requested review from willjohnsonnn

Assignees
No one assigned
Labels
Bug A genuine bug. There must be some form of error exception to work with.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dbauszus-glx @RobAndrewHurst @simon-leech