Err on null password login #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbauszus-glx
requested review from
AlexanderGeere,
RobAndrewHurst,
simon-leech and
cityremade
dbauszus-glx
added
the
Security
|
RobAndrewHurst
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can be added with the api/user/add endpoint. These user have null as password. User with a null password cannot reset their password. The primary use case for these user is to provide a user object for SAML and other third party login.
The account should not get locked trying to login with a random password.
The fromACL method should return an appropriate error when a user with null password attempts to login with password.
The bcrypt method will crash the process attempting to compare string with null/object. This must not happen.
The user must returned as undefined fromACL to prevent the failed login counter to lock the account.