-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layer filter legend render #1121
Layer filter legend render #1121
Conversation
@dbauszus-glx I just pushed two commits to fix issues with the basic and distributed thematic legends. |
…zus-glx/xyz_dev into layer-filter-legend-render
Last commit fixes two issues. The check for Loading images must be conditional whether an image is already loaded. // Assign a load event for the image and load the image.
const image = icon.legendStyle.getImage()
const image1 = image.getImage(1)
if (image1.src) {
onImgLoad()
} else {
image1.addEventListener('load', onImgLoad)
image.load();
} |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this one and worked through the issues I found with @dbauszus-glx
What I've tested:
- Distributed thematic, layer legend is now working after my commit.
- Basic thematic, layer legend is now working after my commit.
- Categorized thematic, you can toggle display of categories in the style legend, or in the filter panel. Toggling in the style panel and filter panel work together and clearing one uses the other (there was an issue where clearing one removed the filter that was resolved by @dbauszus-glx )
The
ni
filter which can be toggled in a categorized legend should be compatible with a different filter type, eg. alike
filter on the same field.A
ni
filter card in the filter panel should be linked to the categorized theme legend. Toggling categories in the legend should re-render the filter. Toggling the category in the filter card should re-render the legend.Filter must cloned from infoj entry into the filter.list. Otherwise a structured clone of the infoj entry will fail after the remove method is assigned to the filter.
Several filter type methods did not make use of the shared applyFilter method.
The
in
filter must return checkboxes in a.filter
class div.The category legend will look for the filter matching the type and field. If a filter.card exists the
.filter
class element will be replacedWith the mapp.ui.layers.filters element.