Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not from if to remove #1155

Merged
merged 9 commits into from
Feb 28, 2024

Conversation

AlexanderGeere
Copy link
Contributor

Clear all filters was just closing the filter panel, but had no effect on the layer.

This fix removes the filter and updates the layer accordingly.

Copy link
Member

@dbauszus-glx dbauszus-glx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A filter set as default should not be cleared.

Screencast.from.26-02-24.11.30.02.webm

The clear all filter text should not show when the filter drawer is collapsed.

@AlexanderGeere
Copy link
Contributor Author

@dbauszus-glx As of my most recent changes, the filter will now be reset to the filter that was present on load. This should correct the behaviour you observed while actually clearing the filter from the layer.

@RobAndrewHurst
Copy link
Contributor

There is still an issue flagged by the scan! Can you fix that @AlexanderGeere

@AlexanderGeere AlexanderGeere added the Bug A genuine bug. There must be some form of error exception to work with. label Feb 27, 2024
@dbauszus-glx dbauszus-glx self-requested a review February 27, 2024 11:04
@dbauszus-glx
Copy link
Member

This works for me now.

The <li> element is shown as selected in the filter dropdown for exsiting filter.

Filter without a field are not attempted to be deleted.

The zoom flag toggle has been removed as not required. Filter panel is unavailable outside zioom range.

Filter is deleted when key array length is falsy.

Copy link

sonarcloud bot commented Feb 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@RobAndrewHurst RobAndrewHurst merged commit 9eda491 into GEOLYTIX:main Feb 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A genuine bug. There must be some form of error exception to work with.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants