-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graduated zeroes error #1170
Graduated zeroes error #1170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexanderGeere Please check my last commit. I think this can be done with array methods. if (!isNaN(catValue) && catValue !== null) {
const isLassThan = cat => catValue <= cat.value;
let index = theme.cat_arr.findIndex(isLassThan)
let cat = theme.cat_arr.at(index)
let catStyle = structuredClone(cat.style || cat)
delete catStyle.label
mapp.utils.merge(feature.style, catStyle)
} |
@dbauszus-glx Works in the I fixed a small typo, and merged main. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working for me too!
When the value on graduated theme is zero the style is never set, even if there is a zero category.
This PR will set the style if one has not been set.
Using
graduated_theme
in bugs_testing, the polygon over birmingham will be blank on main, and will fill with green correctly on this PR.