Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting fix #1178

Merged
merged 10 commits into from
Mar 8, 2024
Merged

Formatting fix #1178

merged 10 commits into from
Mar 8, 2024

Conversation

simon-leech
Copy link
Contributor

@simon-leech simon-leech commented Mar 8, 2024 •
edited by jfitzpatrick17

A few fixes from #1176

  1. In custom views mapp.user.language does not exist - so added mapp.language too.
  2. numericFormatter - if min or max is 0 it wasn't being displayed in the input box.
  3. numericFormatter - if formatter is money, use en-GB locale.
  4. numericFormatter - nullish coalescing assignment of locale.

@simon-leech
mapp.language in custom views
f8903eb
@simon-leech
Fixes
786cd57 
1. If value is 0 - just return it to the filter input box
2. If formatter = money - use en-GB locale
3. Nullish coalescing assignment of locale
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@simon-leech simon-leech added the Bug A genuine bug. There must be some form of error exception to work with. label Mar 8, 2024
@simon-leech simon-leech marked this pull request as ready for review March 8, 2024 10:07
AlexanderGeere
AlexanderGeere approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@AlexanderGeere AlexanderGeere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with formatterparams:{locale: null} - works as expected.

Everything else looks good to me.

@RobAndrewHurst RobAndrewHurst merged commit 3246bd1 into GEOLYTIX:main Mar 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderGeere AlexanderGeere AlexanderGeere approved these changes

@RobAndrewHurst RobAndrewHurst RobAndrewHurst approved these changes

@cityremade cityremade Awaiting requested review from cityremade

@dbauszus-glx dbauszus-glx Awaiting requested review from dbauszus-glx

Assignees
No one assigned
Labels
Bug A genuine bug. There must be some form of error exception to work with.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simon-leech @AlexanderGeere @RobAndrewHurst