Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty cat filter from theme legend #1192

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

dbauszus-glx
Copy link
Member

@dbauszus-glx dbauszus-glx commented Mar 21, 2024

Having a current filter, then toggling a category filter on and off will crash the wkt query because the check on the empty filter passes without checking for the key length.


@dbauszus-glx dbauszus-glx added the Bug A genuine bug. There must be some form of error exception to work with. label Mar 21, 2024
Copy link

sonarcloud bot commented Mar 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using filter.current and toggling the styling using both the cat filter itself and the switch all method and no errors and all working as expected.

@dbauszus-glx dbauszus-glx merged commit febc162 into GEOLYTIX:main Mar 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A genuine bug. There must be some form of error exception to work with.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants