Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide label and names for input elements #1198

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

dbauszus-glx
Copy link
Member

Labels associated with an input should contain the input.

Input elements should have a name.

This is to prevent issues in the google chrome dev tools.

image

@dbauszus-glx dbauszus-glx added the Code Issues related to the code structure and performance. label Mar 27, 2024
Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dbauszus-glx dbauszus-glx linked an issue Mar 27, 2024 that may be closed by this pull request
Copy link
Contributor

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me - i'm not seeing any warnings anymore with checkboxes, gazetteer or sliders.

@RobAndrewHurst RobAndrewHurst merged commit 4ada79d into GEOLYTIX:main Mar 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Issues related to the code structure and performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form element should have an id or name attribute
3 participants