Update Openlayers version and add warning for script loader. #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbauszus-glx
requested review from
cityremade,
AlexanderGeere,
RobAndrewHurst and
simon-leech
dbauszus-glx
added
the
Code
simon-leech
approved these changes
Apr 18, 2024
|
@dbauszus-glx Fixed the warning for if the ol version is bellow what is defined. |
|
Also update the test_view |
RobAndrewHurst
approved these changes
Apr 18, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OL version in the default script has been bumped to 9.1
The OL script loader will be added in the mapp script if OL is not already loaded. It doesn't make sense to load the script if already loaded.
mapp.utils.olScript() will call mapp.ol.load() for legacy support.
mapp.ol.current is the current supported version. e.g. 9.1
The mapp module will warn if the loaded version of OL is below the current version.