Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circle changes #1233

Merged
merged 4 commits into from
May 7, 2024
Merged

Conversation

simon-leech
Copy link
Contributor

@simon-leech simon-leech commented Apr 29, 2024

Opening this up as a draft as its not ready yet.

Changes Included:

If you provide a circle.radius and circle.units then the panel is not provided, and instead you just have the button to begin drawing.
"circle": {
"label": "1km Catchment",
"radius": 1000,
"units": "meter"
}


@simon-leech simon-leech added Feature New feature requests or changes to the behaviour or look of existing application features. Code Issues related to the code structure and performance. labels Apr 29, 2024
Copy link
Member

@dbauszus-glx dbauszus-glx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you break this down into two separate PR? I am ok with the circle change, but believe the geojson import wants to be broken down. Can you create an issue with more details in regards to the specification for the geojson import?

@simon-leech simon-leech changed the title Circle change - geojson import Circle changes May 7, 2024
@simon-leech
Copy link
Contributor Author

@dbauszus-glx I have removed the geojson import from this PR - just got the circle changes now :)

@simon-leech simon-leech marked this pull request as ready for review May 7, 2024 08:41
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dbauszus-glx
Copy link
Member

I added the hidePanel flag in order to maintain the current default behaviour. A radius and unit will always be assigned as default. The config object will just override the defaults. The dictionary label can be assigned in the defaults since the config will override. A spread operator should be used for this rather than object assignment.

Copy link
Contributor Author

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to the Config Docs here -
https://github.com/GEOLYTIX/xyz/wiki/Workspace-Configuration#circle

But all working well for me! :)

@dbauszus-glx dbauszus-glx merged commit 8b68b79 into GEOLYTIX:main May 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Issues related to the code structure and performance. Feature New feature requests or changes to the behaviour or look of existing application features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants