-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circle changes #1233
Circle changes #1233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you break this down into two separate PR? I am ok with the circle change, but believe the geojson import wants to be broken down. Can you create an issue with more details in regards to the specification for the geojson import?
@dbauszus-glx I have removed the geojson import from this PR - just got the circle changes now :) |
Quality Gate passedIssues Measures |
I added the hidePanel flag in order to maintain the current default behaviour. A radius and unit will always be assigned as default. The config object will just override the defaults. The dictionary label can be assigned in the defaults since the config will override. A spread operator should be used for this rather than object assignment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added to the Config Docs here -
https://github.com/GEOLYTIX/xyz/wiki/Workspace-Configuration#circle
But all working well for me! :)
Opening this up as a draft as its not ready yet.
Changes Included:
If you provide a circle.radius and circle.units then the panel is not provided, and instead you just have the button to begin drawing.
"circle": {
"label": "1km Catchment",
"radius": 1000,
"units": "meter"
}