-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabulator 'Set' Headerfilter - no data from distinct query #1237
Tabulator 'Set' Headerfilter - no data from distinct query #1237
Conversation
@AlexanderGeere can you add this to the tabulator plugin? ui.utils.tabulator will be removed from the mapp library as soon as the plugin is reviewed. |
@dbauszus-glx Will do. Changed it slightly so the dropdown works but just says no options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All working well for me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method should not be dependent on the distinct flag but whether an options array is provided.
See filters for reference. https://github.com/GEOLYTIX/xyz/blob/main/lib/ui/layers/filters.mjs
If an array of options is defined than this should be used. If not, a query should be attempted to populate the options for the filter.
Quality Gate passedIssues Measures |
@dbauszus-glx It now checks whether options exists or has a length of 0 and then does the distinct query. |
What
Using the
set
headerfilter
anddistinct
in theheaderFilterParams
would create an error, as the dropdown would attempt to iterate an empty list .This PR should correct that by making a dropdown that has a no data message.
Test Space
bugs_testing/dataviews_filter/workspace.json