Add check on cluster distance being less than 1 #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-leech
requested review from
cityremade,
dbauszus-glx,
AlexanderGeere,
KieronFerrey and
RobAndrewHurst
|
dbauszus-glx
approved these changes
May 1, 2024
RobAndrewHurst
added
the
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to the
cluster.distancevalue to ensure it is more than 1.I noticed a lot of configuration using values less than 1, but this currently silently fails.
This PR simply warns about the issue, forcing the developer to resolve it to remove the warning.