Update docs and allow for numeric filter value. #1307
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
filter_in
function should work on an array of numeric values.eg.
The searchbox function doesn't require a defaultSearch method which was used as a method to append the no search results.
The searchbox function should warn if no searchFunction is provided.
I split the add() and remove() methods from the pills(component) method for clarity.
Updated the docs for
@module /ui/layers/filters, @function filter_in
@module /ui/elements/searchbox, @function searchbox
@module /ui/elements/pills, @function pills, @function add, @function remove
I found this hard to understand.
I prefer to use named variables, where can be the index. Using i as value, and j as index was very hard to understand.
I prefer to use filter separately eg (i<9) opposed to a condition in an array map/forEach method. I prefer to use forEach if nothing is returned from the method which is the point of the map method.