sqlfilter / json url parameter encoding #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbauszus-glx
requested review from
RobAndrewHurst,
cityremade,
simon-leech and
eo-uk
dbauszus-glx
added
the
Bug
simon-leech
requested changes
Oct 31, 2023
There was a problem hiding this comment.
@dbauszus-glx Thanks for this - been doing a little bit of testing.
This is working for filter.current which contains a % or &.
This is working for the legend filter which contains a % or &.
However, the filter module is not working correctly. It throws an error in the console
|
@dbauszus-glx Just pushed a fix to this i think - but needs testing by others. |
simon-leech
approved these changes
Nov 1, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
RobAndrewHurst
approved these changes
Nov 2, 2023
simon-leech
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON does not want to be encoded as stringified URI. A JSON value may contain an ampersand (&) character. The JSON value should be stringified and URLComponent encoded.
The api module script should not be required to decode URI parameter. This should happen by default.
Hence the parameter value is already assumed to be encoded by the time the value is added to [filter] SQLParams array. The skip option for the wildcard is therefore unnecessary.