Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layer.view() method must return layer #995

Merged
merged 1 commit into from
Nov 10, 2023
Merged

layer.view() method must return layer #995

merged 1 commit into from
Nov 10, 2023

Conversation

dbauszus-glx
Copy link
Member

This will allow to compose the method with other methods before or after in a plugin.

Also the listview must not import the view method but use mapp.ui.layer.view.

@dbauszus-glx dbauszus-glx added Feature New feature requests or changes to the behaviour or look of existing application features. Code Issues related to the code structure and performance. labels Nov 9, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

simon-leech
simon-leech approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@simon-leech simon-leech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working for me!

@dbauszus-glx dbauszus-glx merged commit 9f6efb2 into GEOLYTIX:main Nov 10, 2023
6 checks passed
@dbauszus-glx dbauszus-glx deleted the ui-layer-view branch January 29, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-leech simon-leech simon-leech approved these changes

@RobAndrewHurst RobAndrewHurst Awaiting requested review from RobAndrewHurst

@cityremade cityremade Awaiting requested review from cityremade

@eo-uk eo-uk Awaiting requested review from eo-uk

Assignees
No one assigned
Labels
Code Issues related to the code structure and performance. Feature New feature requests or changes to the behaviour or look of existing application features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dbauszus-glx @simon-leech