Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer should be merged into workspace values #999

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Layer should be merged into workspace values #999

merged 2 commits into from
Nov 14, 2023

Conversation

simon-leech
Copy link
Contributor

@simon-leech simon-leech commented Nov 13, 2023

This PR simply reverses the merging order of the getLayer.js,
The object (e.g layer) should be merged into the template not the other way around.
This is so we can overwrite values defined in a layer template via the workspace

"template": {
"name": "NEW NAME"
}

This would overwrite the name value defined on the template, allowing for flexibility from within teh workspace.

@simon-leech simon-leech marked this pull request as ready for review November 13, 2023 15:07
@simon-leech simon-leech marked this pull request as draft November 13, 2023 15:16
Copy link
Member

@dbauszus-glx dbauszus-glx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the template and locale merge was the wrong way as well. Can you test the last commit.

Copy link

sonarcloud bot commented Nov 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dbauszus-glx dbauszus-glx added the Bug A genuine bug. There must be some form of error exception to work with. label Nov 13, 2023
@dbauszus-glx dbauszus-glx self-requested a review November 13, 2023 15:32
@simon-leech simon-leech marked this pull request as ready for review November 14, 2023 09:34
@RobAndrewHurst RobAndrewHurst merged commit 4a547b7 into GEOLYTIX:main Nov 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A genuine bug. There must be some form of error exception to work with.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants