-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding SourceFluxStatistics #2954
Merged
Merged
Changes from all commits
Commits
Show all changes
110 commits
Select commit
Hold shift + click to select a range
d73ac6d
added region mass stats
MelReyCG 909a1c5
added region temperature stats
MelReyCG 8bee3cf
Logging debug info - to be removed laster
MelReyCG 256caeb
better debug output
MelReyCG 0ec69b5
annotations
MelReyCG 67d8a7e
cleaning
MelReyCG 27bec78
Output flux stats in log
MelReyCG f89e2d8
completed previous commit
MelReyCG e0592ed
Add the logLevel viewkey & description
MelReyCG 078e6ed
Add a way to expend the description of a wrapper
MelReyCG 5b8f213
Intermediate progress to properly store the SourceFlux stats
MelReyCG 953ec3a
adding the SourceFluxStatistics Task which will allow to aggregate st…
MelReyCG 1a9fe0c
simplify description to avoid regenerating a lot of .rst (to be added…
MelReyCG 867a20c
Merge remote-tracking branch 'origin/develop' into feature/rey/source…
MelReyCG 814fd34
missed a few details
MelReyCG 818fcc2
forgotten generated files...
MelReyCG a5d762b
SourceFlluxStatistics now compiles
MelReyCG 28a7730
generated docs
MelReyCG 4e71130
SourceFluxStatistics now runs:
MelReyCG cc55358
few edits
MelReyCG 69c6918
uncrustify
MelReyCG a164ece
architecture adaptations to expose values to unit tests
MelReyCG badfc4e
added singlephase test
MelReyCG 23e41fc
removed debug infos
MelReyCG d59318a
unit test: code layout, removed debug info
MelReyCG db72798
unit test: code layout, removed debug info, xmlInput improvements
MelReyCG 232106b
Merge branch 'feature/rey/sourceflux-stats' of https://github.com/GEO…
MelReyCG 8477262
Added multiphase xml input
MelReyCG 317560a
few comments
MelReyCG af7be1e
code style
MelReyCG 796f020
unit test: Added checks on every timesteps stats
MelReyCG c6ccc63
unit test: separated the input parameters and expected value set
MelReyCG b806da7
unit test: cleaning comments
MelReyCG aa4b250
unit test: compositional multiphase sim now runs
MelReyCG c2fa0f8
allowed multiple component stats for SourceFluxStatistics
MelReyCG dc3398c
changed singlephase parameters so that they are not multiple among th…
MelReyCG c2c74f0
forgot to replace some hard coded values
MelReyCG 0a0fb7b
Whole multiphase sim stat check
MelReyCG e2ac446
crash investigating...
MelReyCG 4c3fa0b
fixed crashed :)
MelReyCG 41b0fc8
Revert unwanted pushed files
MelReyCG f163aed
Finished the multiphase test
MelReyCG 1781ac9
Unexpected result debugging
MelReyCG 620a53b
forgotten decls
MelReyCG 45f7452
code cleaning
MelReyCG 703b73a
fixing gpu captures + adding support for ReactiveCompositionalMultiph…
MelReyCG cdebcff
fixed sum operations (=> reduceSum)
MelReyCG ffcf39b
uncrustify
MelReyCG 7a96ee2
test pvt tables optimisation (13.4s -> 3.0s)
MelReyCG 2446436
exposed SinglePhaseStatistics::RegionStatistics
MelReyCG a0d085a
compared mass difference from SinglePhaseStatistics and SourceFluxSta…
MelReyCG e427189
Merge branch 'develop' into feature/rey/sourceflux-stats
MelReyCG e1e79cf
fixed typo
MelReyCG 3da5569
Merge branch 'feature/rey/sourceflux-stats' of https://github.com/GEO…
MelReyCG e9f7f4a
Added guard to test sub-timesteps
MelReyCG 6af8726
Added CSV export & more docs
MelReyCG 3d19803
Removing the MultifluidBase::useMass wrapper as it is set by the solv…
MelReyCG a2d618a
fixed catalog name of TimeStepChecker
MelReyCG 7ee9b4d
Fixed solver "amount of fluid" units (kg or mol), and added documenta…
MelReyCG 7378ec2
better timestep cut checking + refactored a bit
MelReyCG 322a3f8
Merge remote-tracking branch 'origin/develop' into feature/rey/source…
MelReyCG 0161b19
generated docs
MelReyCG d6a47d8
uncrustify
MelReyCG c528da8
typo
MelReyCG 5907f9c
reverting undesired paste
MelReyCG 720c493
wrappers like this one is required to be able to "deliverClone()"
MelReyCG afab7c7
generated documentations
MelReyCG 1e33b3d
docs
MelReyCG f911df3
wrong doxygen keyword
MelReyCG 8dfe5db
doxygen test
MelReyCG 2662637
test2
MelReyCG 7fcf887
fixed doxygen
MelReyCG ffaf9d4
ajusting test value to facilitate convergence
MelReyCG e9ee4ea
code reordering + docs
MelReyCG a9d17d4
debugging sub-sub-timestep behaviour
MelReyCG 2003fd2
finally fixed numerical precision issue
MelReyCG 45084b5
removing double decl
MelReyCG 000978a
removing unrelated code change
MelReyCG 923b0d8
ajusting test value to facilitate convergence
MelReyCG 02d35fc
test
MelReyCG f53a8f5
allow non converged solution is tests as trilinos struggles with the …
MelReyCG d5b4a14
Solver setting test
MelReyCG fad3edf
Solver setting test 2 (Mass test is passed with trilinos)
MelReyCG 68eb991
Solver setting test
MelReyCG 9b0628f
reverted to previous settings
MelReyCG adab7a0
forgotten ILUK attribute
MelReyCG 32cdd5e
trying to test sub-timesteps only with hypre
MelReyCG 42a57d8
trilinos & hyper work in stastifying time
MelReyCG 7f2a913
removed unused headers
MelReyCG 7f51542
Merge remote-tracking branch 'origin/develop' into feature/rey/source…
MelReyCG dc5b827
solver precision
MelReyCG 7f9097c
avoiding exact 0 / 1 values in test
MelReyCG de20aba
removed parameter as they are to defualt values
MelReyCG 9f78b8d
renaming testFluidStatistics to testFlowStatistics
MelReyCG 25bc30f
removing the 4th log level
MelReyCG f56b2f6
missing inlines
MelReyCG 37b3c97
xsd / rst changes
MelReyCG 3165aef
moving the TimeStepChecker in its own file (& created a testingUtilit…
MelReyCG 9905ae1
Merge remote-tracking branch 'origin/develop' into feature/rey/source…
MelReyCG 3883d39
moving some definition to cpp
MelReyCG 8f72e9f
uncrustify :s
MelReyCG 43fe9f4
few adjustments
MelReyCG 34fc78d
Merge commit '79856a0e653a508b4fe4dcd8c582fcdc2838b756' into feature/…
MelReyCG cf15bb3
added an header due to incomplete DomainPartition type
MelReyCG b051ed1
by default, SourceFluxStat targets al SourceFlux + adapted test
MelReyCG cf0271a
generated files
MelReyCG b0c7fe6
Added star character * in group name reference regex.
MelReyCG db2efea
Merge branch 'develop' into feature/rey/sourceflux-stats
paveltomin ce24a37
Merge branch 'develop' into feature/rey/sourceflux-stats
paveltomin fc11f5b
Merge branch 'develop' into feature/rey/sourceflux-stats
paveltomin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Units are not really strongly enforced in GEOS. One could use any set of units as long as they are consistent. For example a user can decide to specify pressures in MPa an adjust all other properties. I would say that we either properly introduce a unit parser or these units can easily be false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About this header, it is in S.I. by default (following the GEOS convention). Some units can be in other systems as you can see for the temperatures (°C rather than °K), and if someone want to add more, I think it should come with conversion functions.
I strongly advise to add comments on all non-S.I. variables / method, it would be less error-prone and would help when implementing a parsing unit system or when adding new outputs.
About adding unit parsing system, it is on my roadmap. Feel free to add suggestions on my EPIC.