Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Geos against TPLs with ENABLE_CUDA=OFF on pangea3 #264

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Algiane
Copy link
Contributor

@Algiane Algiane commented May 16, 2024

Using the ThirdPartyLibraries with the pangea3-gcc8.4.1-openmpi-4.1.2.cmake host-config file and the -DENABLE_CUDA=OFF option compiles HYPRE with CUDA flags and the other TPLs without CUDA flags. This results in a set of software that can't be used to build Geos.

This PR proposes to ensure that the entire suite of TPLs is built with compatible flags (so the build of Geos will not fail):

  1. if the ENABLE_CUDA variable is explicitely setted to OFF by the user and Hypre is asked to be built with CUDA, a warning is raised saying that Hypre will ignore the CUDA config.
  2. Even if useless with the previous modification, I find it useful to provide to the user host-config files where dependencies between options are explicitely shown so I have modified the P3 host-config file in order to set Hypre device to CUDA only when ENABLE_CUDA is on.

It is linked to:

@Algiane Algiane changed the title Build Geos aginst TPLs with ENABLE_CUDA=OFF on pangea3 Build Geos against TPLs with ENABLE_CUDA=OFF on pangea3 May 16, 2024
@Algiane Algiane linked an issue May 16, 2024 that may be closed by this pull request
@Algiane Algiane added bug Something isn't working flag: ready for review labels May 17, 2024
@Algiane Algiane self-assigned this May 17, 2024
CMakeLists.txt Outdated Show resolved Hide resolved
@Algiane Algiane removed the request for review from rrsettgast May 24, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation failure on pangea-3 if ENABLE_CUDA is OFF
2 participants