Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option ALT_ESMF #161

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Added option ALT_ESMF #161

wants to merge 9 commits into from

Conversation

aoloso
Copy link

@aoloso aoloso commented Apr 2, 2021

Added optional variable ALT_ESMF in FindBaselibs to select a non-default ESMF installation i.e. ESMF installation other than the one in BASEDIR

@aoloso
Added option to FindBaselibs.cmake to use a different ESMF build than…
7452cd6 
… the one in BASEDIR. The user adds '-DALT_ESMF=<path_to_alternative_esmf_install>' to when invoking cmake
@aoloso
Modified the ALT_ESMF option
5795efb
@aoloso aoloso requested review from mathomp4 and tclune April 2, 2021 23:05
@aoloso aoloso requested a review from a team as a code owner April 2, 2021 23:05
@aoloso aoloso linked an issue Apr 2, 2021 that may be closed by this pull request
Add switch that optionally finds ESMF from location other than main baselibs #160
Open
tclune
tclune requested changes Apr 4, 2021
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we expect to set this option on the command line, it needs to be established with a cmake set . Something like

set(ALT_ESM "" CACHE PATH "Path to ESMF installation")

2nd, I think a better name for this option would be ESMF_DIR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune requested changes

@mathomp4 mathomp4 Awaiting requested review from mathomp4

Requested changes must be addressed to merge this pull request.

Assignees

@mathomp4 mathomp4

@tclune tclune

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add switch that optionally finds ESMF from location other than main baselibs
3 participants
@aoloso @tclune @mathomp4