Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 0.66 MOM6 set up. #21

Merged
merged 5 commits into from
Mar 15, 2023
Merged

Add 0.66 MOM6 set up. #21

merged 5 commits into from
Mar 15, 2023

Conversation

yvikhlya
Copy link
Contributor

@yvikhlya yvikhlya commented Mar 2, 2023

Add 0.66 MOM6 set up.

@yvikhlya yvikhlya added 0 diff structural Structural changes to repository that are zero-diff enhancement New feature or request labels Mar 2, 2023
@yvikhlya yvikhlya requested a review from a team as a code owner March 2, 2023 20:54
@yvikhlya yvikhlya self-assigned this Mar 2, 2023
@sanAkel sanAkel self-requested a review March 3, 2023 14:36
@sanAkel sanAkel added the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Mar 3, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff structural, Contingent - DNA, enhancement

@sanAkel
Copy link
Collaborator

sanAkel commented Mar 3, 2023

@yvikhlya:

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff structural, Contingent - DNA, enhancement

@yvikhlya
Copy link
Contributor Author

yvikhlya commented Mar 3, 2023

I was actually trying to avoid polluting repo with multiple copies of MAPL_Tripolar.cdl as unnecessary. This is a trivial config edit for each grid, which is needed anyway, because location of input data is not permanent. Anyway, if it helps, here it is.

This PR can be merged independently from other PRs, it will not break anything.

@sanAkel
Copy link
Collaborator

sanAkel commented Mar 3, 2023

I was actually trying to avoid polluting repo with multiple copies of MAPL_Tripolar.cdl as unnecessary. This is a trivial config edit for each grid, which is needed anyway, because location of input data is not permanent. Anyway, if it helps, here it is.

Thanks for adding it. Having it allows quick reproducibility, or else everyone has to make it. Also good to have the metadata
recorded here.

This PR can be merged independently from other PRs, it will not break anything.

Yes, true.

@sanAkel sanAkel removed the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Mar 3, 2023
MOM6_GEOSPlug/mom6_app/540x458/README.md Outdated Show resolved Hide resolved
@sanAkel sanAkel merged commit 19e94ce into develop Mar 15, 2023
@sanAkel sanAkel deleted the yv/feature/mom6-0.66deg branch March 15, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff structural Structural changes to repository that are zero-diff enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants