Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remap upper stretched cube in #61

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

weiyuan-jiang
Copy link
Contributor

The branch is a merge of the branches feature/wmputman/remap_upper_stretched_cube_in and main. Testing is underway...

@weiyuan-jiang weiyuan-jiang added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request labels Feb 21, 2024
wmputman
wmputman previously approved these changes Apr 10, 2024
Copy link
Contributor

@wmputman wmputman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mathomp4
Copy link
Member

I believe, per @weiyuan-jiang, that this relies on updates in FVdycoreCubed_GridComp, so it should probably be undrafted when @sdrabenh undrafts all the other update PRs.

@biljanaorescanin
Copy link
Contributor

Well its mix of all of these:
GEOS_Util | (b) feature/wjiang/bill_remap_upper_stretched_cube_in
MAPL | (b) feature/wmputman/KM_v11_5_1_remap_upper
GEOSgcm_GridComp | (b) feature/wmputman/KM_v11_5_1_post_mgb_updates
FVdycoreCubed_GridComp | (b) feature/wmputman/KM_v11_5_1_remap_upper
fvdycore | (b) feature/wmputman/KM_v11_5_1_remap_upper
GEOSgcm_App | (b) feature/sshakoor/linking_new_bcs

@mathomp4
Copy link
Member

Note for @weiyuan-jiang, @wmputman has an update for the milans on a branch: feature/wmputman/KM_v11_5_1_remap_upper

You can see the differences here:

feature/wjiang/bill_remap_upper_stretched_cube_in...feature/wmputman/KM_v11_5_1_remap_upper

I'm mainly talking about the MPI settings. I'm not too sure what the other changes are (QOS and Ostia).

@biljanaorescanin
Copy link
Contributor

If we run our testing package all our tests will fail for upper restarts when compared to baseline. All tests are CF.
Surface restarts are the same.
Here are tests outputs:
/discover/nobackup/borescan/REMAP_TESTS/
and here is baseline we compare with:
/discover/nobackup/projects/gmao/SIteam/Remapping_Test_Cases/

@sdrabenh @wmputman who is best to help us with validation of upper restarts? Someone needs to confirm this is what we want to see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants