Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

San akel patch 2 #167

Merged
merged 3 commits into from
Sep 24, 2020
Merged

San akel patch 2 #167

merged 3 commits into from
Sep 24, 2020

Conversation

sanAkel
Copy link
Collaborator

@sanAkel sanAkel commented Sep 22, 2020

Split saltwater restart: bug fix for running emip and correct exit status

Fix check/exit condition for split saltwater restarts
Replace `EXPDIR` with `SCRDIR` for EMIP to work as well.
@sanAkel sanAkel requested a review from a team as a code owner September 22, 2020 16:42
@sdrabenh sdrabenh added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs labels Sep 22, 2020
`split saltwater restarts`
make the logic simpler: just check if there is exists, rather than _not exist_
@sdrabenh sdrabenh removed the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Sep 24, 2020
@sdrabenh sdrabenh merged commit 5137e9a into develop Sep 24, 2020
@sdrabenh sdrabenh deleted the sanAkel-patch-2 branch September 24, 2020 20:19
tclune added a commit that referenced this pull request Sep 30, 2020
Trivial change to configuration, but with desirable results.

Other:

 - introduced new "legacy" format for those that do not want the
   message annotations.
 - also a bit of cleanup
sdrabenh added a commit that referenced this pull request Oct 7, 2020
…ging-config

Fixes #167 - duplicated pflogger messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants