Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving to v12 BCS #616

Merged
merged 5 commits into from
Jun 10, 2024
Merged

Moving to v12 BCS #616

merged 5 commits into from
Jun 10, 2024

Conversation

biljanaorescanin
Copy link
Contributor

This PR will offer v12 boundary conditions version instead of v11.
We are moving from v11 after we fixed a localized bug user found in the set over Argentina.

More details on that bug fix are in this PR: GEOS-ESM/GEOSgcm_GridComp#944
Set was verified in offline simulations by @gmao-rreichle

Set is used in testing for future default BCS candidate.

@biljanaorescanin biljanaorescanin added enhancement New feature or request 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) labels Jun 7, 2024
@biljanaorescanin
Copy link
Contributor Author

@mathomp4, @sdrabenh not sure about this run fail for me in sandbox all runs, any ideas?

@biljanaorescanin biljanaorescanin marked this pull request as ready for review June 10, 2024 14:44
@biljanaorescanin biljanaorescanin requested a review from a team as a code owner June 10, 2024 14:44
@gmao-rreichle
Copy link
Contributor

@mathomp4, @sdrabenh not sure about this run fail for me in sandbox all runs, any ideas?

Are the required v12 bcs in place?

@gmao-rreichle
Copy link
Contributor

gmao-rreichle commented Jun 10, 2024

@mathomp4, @sdrabenh not sure about this run fail for me in sandbox all runs, any ideas?

PS: I just realized that the "build" fails, not the "run". So potential lack of a specific resolution of v12 bcs doesn't explain it (but may still be an issue).
PPS: My bad -- the "build-test" failed because the "run" tests failed. So could it be the lack of v12 bcs after all?

@biljanaorescanin
Copy link
Contributor Author

Are the required v12 bcs in place?

I think all we use is there now. But here is path if someone wants to check:
/discover/nobackup/projects/gmao/bcs_shared/fvInput/ExtData/esm/tiles/v12/geometry
I do need to run stretched grid and high res cases but all including C360 and lower is there.

@mathomp4
Copy link
Member

@gmao-rreichle @biljanaorescanin My guess is you've broken the scripts I used to make experiments. They are sensitive to changes in gcm_setup sometimes (especially if a question changes).

I'll need to clone this on discover and track that down fix my scripts and then update the CI to recognize it.

@mathomp4
Copy link
Member

Okay. First CI fix attempt running...

@sdrabenh sdrabenh merged commit 8264a28 into develop Jun 10, 2024
10 checks passed
@sdrabenh sdrabenh deleted the feature/borescan_v12_bcs branch June 10, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants