-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WORK IN PROGRESS: Updates for Standards Conformance (NAG) #500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathomp4
added
0 diff
The changes in this pull request have verified to be zero-diff with the target branch.
Contingent - DNA
These changes are contingent on other PRs (DNA=do not approve)
labels
Dec 15, 2021
mathomp4
removed
the
0 diff
The changes in this pull request have verified to be zero-diff with the target branch.
label
Dec 15, 2021
mathomp4
added
the
0 diff
The changes in this pull request have verified to be zero-diff with the target branch.
label
Feb 3, 2022
@mathomp4 mind if I close this for now? It looks very old |
Okay. The merge worked, which is good. For now I'll close the PR and can always bring it back if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0 diff
The changes in this pull request have verified to be zero-diff with the target branch.
Contingent - DNA
These changes are contingent on other PRs (DNA=do not approve)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tracks changes needed to compile GEOSgcm_GridComp with the NAG Compiler. NAG is very strict and will not allow the use of Fortran extensions that are endemic to GEOS.
The first category are procedures that are now part of the Fortran Standard that used to be extensions in some compilers:
iargc()
→command_argument_count()
getarg()
→get_command_argument()
getenv()
→get_environment_variable()
system()
→execute_command_line()
call exit(0)
→stop
call exit(N)
→error stop N
NAG also doesn't support (without flags that need to be used everywhere as @tclune can elucidate on) the use of
real*4
orreal(kind=4)
. The reason is that NAG does not use 4 for 32-bit real and 8 for 64-bit, instead they use 1 and 2. (The Standard does not specify what "kind" a 32-bit real must be, only that there must be one.) So, many changes are of the type:real*4
→real(REAL32)
real(kind=8)
→real(kind=REAL64)
Finally, in this, some catch code uses
nan
andinf
defined like:NAG does not allow this as it sees these as, well, not numbers at compile-time. So with @tclune we made functions to return these values via
ieee_arithmetic
a la: