-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make_bcs clarification of options #517
Conversation
@biljanaorescanin,
Are the bcs generated before and after this change 0-diff? Even though there isn't a nightly test for make_bcs, we still need to make sure and test that the make_bcs package is 0-diff. |
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/make_bcs
Outdated
Show resolved
Hide resolved
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/make_bcs
Outdated
Show resolved
Hide resolved
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/mkCatchParam.F90
Outdated
Show resolved
Hide resolved
...cm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/mod_process_hres_data.F90
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for copying me on your PR!
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/make_bcs
Outdated
Show resolved
Hide resolved
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/mkCatchParam.F90
Outdated
Show resolved
Hide resolved
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/rmTinyCatchParaMod.F90
Show resolved
Hide resolved
I changed run setup. Is that what you had in mind @gmao-rreichle ? Now user runs from build directory and makes on screen choice for experiment dir. |
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/make_bcs
Outdated
Show resolved
Hide resolved
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/make_bcs
Outdated
Show resolved
Hide resolved
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/make_bcs
Outdated
Show resolved
Hide resolved
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/make_bcs
Outdated
Show resolved
Hide resolved
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/make_bcs
Outdated
Show resolved
Hide resolved
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/make_bcs
Outdated
Show resolved
Hide resolved
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/make_bcs
Outdated
Show resolved
Hide resolved
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/make_bcs
Outdated
Show resolved
Hide resolved
@gmao-rreichle was this what you had in mind for help message? I left usage text the same just moved it to be on screen if added "-h" . |
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/Utils/Raster/make_bcs
Outdated
Show resolved
Hide resolved
@gmao-rreichle I've added revision so we can address the potential for specifying more than one set of bcs. It will just add to directory name all resolutions separated by "_" . I've removed left over module sourcing. |
- fixed check for existing/empty output directory - fixed check for EASE grid and ocean resolution - revised help text
@biljanaorescanin: There are two things left to do:
|
This PR needs to make clear separation of what user is choosing on screen for boundary conditions creation. We had recent issue where under development branch was used as suggested default. Hopefully this PR will help with that.
I've added to PR two small fixes one is mask we use for EASE grid. To be aligned with what archived EASE grid boundary conditions used in past. Other is format when CatchCN_CLM4.5 boundary conditions are created.
Since all of the changes are only triggered during run for boundary conditions creation package it is a zerodiff PR.
@gmao-rreichle @sanAkel let me know if either of you wants me to add or remove something.
UPDATED 9 Feb 2022 by @gmao-rreichle:
The PR now includes the following changes:
make_bcs
(primary user interface)mkCatchParam.F90
create_README.csh
mk_GEOSldasRestarts.F90
The PR is trivially 0-diff for all current model and GEOSldas tests because it only touches code that is not exercised in any of the current tests. The land group verified that bcs generated after and just before the above modifications are 0-diff.
(Note that the archived bcs in /discover/nobackup/ltakacs/bcs were generated with a much older version and are not 0-diff against bcs generated with the current make_bcs package. The land group verified that the archived bcs are scientifically equivalent to bcs generated with the current make_bcs package.)
@sdrabenh @rdkoster @biljanaorescanin